-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/updates for v5 #246
Feat/updates for v5 #246
Conversation
|
The Also, a word of warning: this is a complicated module. We are likely going to want @mcollina's input on this one. |
This PR now contains the updates I'm aware of being needed from fastify/fastify#5116. If something additional needs to happen (as either this PR or a separate one) we can discuss it either here or in #245. |
I think we can combine them in If I understand correctly, @Uzlopak just removed Edit: asked Uzlopak directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
* chore: remove express (#227) * Feat/updates for v5 (#246) * Sync gitignore with fastify/skeleton * Update workflows for fastify v5 * Update all dependencies * merge --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> * update fastify deps --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: Uzlopak <aras.abbasi@googlemail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: Nicholas Rayburn <52075362+nrayburn-tech@users.noreply.github.com>
Fixes #245.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct